StaxEventItemWriter writes extra end document tag

I using spring batch for reading data from db and writing to XML file i am choosed the "StaxEventItemWriter" writes. it generating the xml file fine but with extra end document tag at the end. You can find the bug Here, due to this my batch process was failed to read the same XML file. I surf the internet and i found the one of the solution and  implemented the below. Now my XML files are generated without the extra end document tag. Now all my batches are working fine.

Solution:

import javax.xml.stream.XMLEventWriter;
import javax.xml.stream.XMLOutputFactory;
import javax.xml.stream.XMLStreamException;

import org.springframework.batch.item.xml.StaxEventItemWriter;

/**
 * @author sunilkumar.gutti
 * 
 */
@SuppressWarnings("rawtypes")
public class ShipmentStaxEventItemWriter extends StaxEventItemWriter {
    @Override
    protected void endDocument(XMLEventWriter writer) throws XMLStreamException {
        XMLOutputFactory outputFactory = XMLOutputFactory.newInstance();
        if (outputFactory.isPropertySupported("com.ctc.wstx.autoCloseElements")) {
            outputFactory.setProperty("com.ctc.wstx.autoCloseElements", false);
        }
    }

}

Spring batch restrict single instance of job only

I have one spring batch job which can be kicked of by rest URL. I want to make sure only one job instance is allowed to run. and if another instance already running then don't start another. even if the parameters are different.
I searched and found nothing out of box solution. thinking of extending SimpleJobLauncher. to check if any instance of the job running or not.

Answers

You could try to intercept the job execution, implementing the JobExecutionListener interface:

public class MyJobExecutionListener extends JobExecutionListener {

//active JobExecution, used as a lock.
private JobExecution _active;

public void beforeJob(JobExecution jobExecution) {
    //create a lock
    synchronized(jobExecution) {
        if(_active!=null && _active.isRunning()) {
            jobExecution.stop();
        } else {
            _active=jobExecution;
        }
    }
}

public void afterJob(JobExecution jobExecution) {
      //release the lock
      synchronized(jobExecution) {
          if(jobExecution==_active) {
            _active=null; 
          }
      }
}

}
And then, inject to the Job definition:

<job id="myJobConfig">
    <listeners>
        <listener ref="myListener"/>
    </listeners>
</job>

Or, in response to REST URL, check using JobExplorer if your job is running using job's specifics business rules

I solved this by creating an JobExecutionListner and with the help of JobExplorer I checked if any other instance is running if running then stop current job.I created listener so that it can be plugged in to any job that requires this kind of scenario.

Set<JobExecution> jobExecutions = ((SimpleJobExplorer) jobExplorer.getObject()).findRunningJobExecutions(jobExecution.getJobInstance().getJobName());
            if(jobExecutions.size()>1){
                Long currentTime = (new Date()).getTime();
                for(JobExecution execution : jobExecutions ){
                    if(execution.getJobInstance().getId().compareTo(jobExecution.getJobInstance().getId())!=0 && (currentTime - execution.getStartTime().getTime()) <lockOverideTime){
                        jobExecution.stop();
                        throw new IllegalStateException("Another instance of the job running job name : " +jobExecution.getJobInstance().getJobName() );

                    }
                }

            }

source : here